fix: remove node from exports map #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyletsang
commented
Jun 25, 2025
| @@ -3,6 +3,8 @@ | |||
| "compilerOptions": { | |||
| "jsx": "react-jsx", | |||
| "lib": ["DOM", "ESNext"], | |||
| "moduleResolution": "bundler", | |||
There was a problem hiding this comment.
Fixes errors when viewing test files in the IDE since this isn't needed for vitest
|
@jquense A review would be highly appreciated. AFAICS this PR currently blocks the attempt to get |
|
@jquense bump! |
|
This is a very minor change and we can fix stuff in a follow-up PR if needed. It does fix the type resolution issue in RB, so let's see what else appears in the next beta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't think the node field in exports map is required anymore since this now supports proper ESM. This is causing an issue in RB when consuming from an ESM perspective since types are resolving to the CJS variant.